[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability

  • To: John Levon <levon@xxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Wed, 10 Jan 2007 18:21:05 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 10 Jan 2007 10:20:44 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acc05Bc2Va8U+qDXEduNDgAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Partial fix for compat build non-portability

On 10/1/07 17:37, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> Still to be resolved is the pragma pack push issue; this is non-portable
> pragma only enabled on some targets, as it's intended for win32
> compatibility not something for general use. We should be wrapping each
> structure in a pragma pack(4) / pragma pack() pair, but trying to fix
> that makes my head hurt, and Jan isn't interested.

We only care about it working for the x86/64 target since that's the only
one that asserts CONFIG_COMPAT. Why would wrapping structs individually be
better than wrapping whole header files?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.