[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true'

  • To: <caglar@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Wed, 10 Jan 2007 10:31:30 +0000
  • Delivery-date: Wed, 10 Jan 2007 02:31:16 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acc0on2avBuvI6CVEduNDgAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true'

On 10/1/07 01:18, "S.ÃaÄlar Onur" <caglar@xxxxxxxxxxxxx> wrote:

> Attached patch adds "-Wno-always-true" CFLAGS into xen/arch/powerpc/Rules.mk
> and xen/arch/x86/Rules.mk, else compiling xen with latest gcc-4.2.0 snapshot
> fails, patch is against current xen-3.0.4-testing repo;

If that is the *only* build error, then we can just get rid of that
BUG_ON(). It doesn't work any more anyway (that symbol is never zero, even
during initial kernel link when no symbol info is available).
BUG_ON(symbols_num_syms == 0) is probably the right replacement.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.