[Xen-devel] [PATCH] Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken)

[Magnus Damm <magnus@xxxxxxxxxxxxx>]

Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken)

Kdump has been broken since xen-3.0.4-testing.hg-13109.
Many thanks to Hiromichi Itou for tracking this down.

Signed-Off-By: Magnus Damm <magnus@xxxxxxxxxxxxx>

---

Applies to xen-3.0.4-testing-13130.

--- 0001/xen/common/lib.c
+++ work/xen/common/lib.c       2007-01-10 11:18:38.000000000 +0900
@@ -442,7 +442,7 @@ s64 __moddi3(s64 a, s64 b)
 unsigned long long parse_size_and_unit(const char *s, const char **ps)
 {
        unsigned long long ret;
-       const char *s1;
+       const char *s1 = NULL;
 
        ret = simple_strtoull(s, &s1, 0);
 
@@ -454,7 +454,7 @@ unsigned long long parse_size_and_unit(c
        case 'K': case 'k':
                ret <<= 10;
        case 'B': case 'b':
-               s++;
+               s1++;
                break;
        default:
                ret <<= 10; /* default to kB */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel