Re: [Xen-devel] [PATCH] fix free of event channel in blkfront

["Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>]

Hi Steven,

> > > > We tested the xm block-attach/detach command.
> > > > It repeats block-attach/detach command for DomU and pv-on-hvm on HVM Domain.
> > > > (block-attach -> block-detach -> block-attach -> block-detach -> ...)
> > > >
> > > > The block-attach command failed when repeating 256 times.
> > > I can't reproduce this - just tested 500 or so attach/detach pairs in
> > > a tight loop and worked for me. However I was using a regular domU -
> > > is it pv-on-hvm only? Can you give a more detailed repro case (or a
> > > script)?
It already seems to have been corrected.

・xen-unstable.hg : cs 13198
 [PV-ON-HVM] Update evtchn interface to match new PV Linux interfaces.

----------------------------------------------------------------------------------------------------
--- a/unmodified_drivers/linux-2.6/platform-pci/evtchn.c	Sat Dec 30 18:23:27 
2006 +0000
+++ b/unmodified_drivers/linux-2.6/platform-pci/evtchn.c	Sun Dec 31 11:59:47 
2006 +0000
@@ -118,8 +144,12 @@ void unbind_from_irqhandler(unsigned int

        mask_evtchn(evtchn);
        evtchns[evtchn].handler = NULL;
+
+       if (evtchns[evtchn].close) {
+               struct evtchn_close close = { .port = evtchn };
+               HYPERVISOR_event_channel_op(EVTCHNOP_close, &close);
+       }
}
-
EXPORT_SYMBOL(unbind_from_irqhandler);

void notify_remote_via_irq(int irq)
----------------------------------------------------------------------------------------------------


However, the following problems remain.
I think that it operates if the following problems can be solved.

It is necessary to correct pv-on-hvm according to the following corrections.

・xen-unstable.hg : cs 13197
 [LINUX] Extend the event-channel interfaces to provide helper methods


> I confirmed it with up-to-date xen-unstable.hg. (cs 13282)
>
> It did not reproduce it in DomU.
> Because VBD was not able to be used, pv-on-hvm was not able to confirm it.
> The following errors occur.
>
> # insmod xen-vbd.ko
> xen-vbd: Unknown symbol irq_to_evtchn_port
> insmod: error inserting 'xen-vbd.ko': -1 Unknown symbol in module
Thanks,

--
Takanori Kasai 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel