Re: [Xen-devel] [PATCH] x86_emulate adjustments

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 5/1/07 11:57, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> I can't see, however, what value there would particularly be in merging the
> privop decoder into x86_emulate - it's pretty orthogonal to the current
> functionality there, except for the memory accessed resulting from ins/outs.
> To a lesser degree, merging the hvm_instrlen into the main code seems not
> desirable for performance reasons, unless you mean to share the lookup table,
> but keep the routine separate.

Yes, the table-driven hvm_instrlen will stay I think. The generic
hvm_instrlen() is only used by the mmio emulator, and that's going away.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel