Dependency checking - early was Re: [Xen-devel] 3.0.3 without X

[Steve Kemp <steve@xxxxxxxxxxxx>]

On Thu, Jan 04, 2007 at 10:31:14PM +0000, Ewan Mellor wrote:

> Certainly!  Patches to documentation such as the README and the user guide are
> always welcome.  This is a great way that people can help out -- by writing
> down the things that catch you out the first time around.

  I was about to report something like this myself this week.  Too often
 I install Xen on a new host and miss a dependency due to carelessness.

  Please find a patch below to "make world" which first runs "make tools/check"
 hopefully making sure that all dependencies are present and detected
 early.

  (Most frustrating is missing libssl, or libz, which is only otherwise
 detected right at the end of a kernel build.)

Steve
-- 

--- Makefile~   2006-12-23 21:17:38.000000000 +0000
+++ Makefile    2007-01-05 09:29:04.000000000 +0000
@@ -30,6 +30,13 @@
        $(MAKE) -C tools build
        $(MAKE) -C docs build

+#
+#  Check dependencies.
+#
+.PHONY: check
+check:
+       $(MAKE) -C tools/check
+
 # The test target is for unit tests that can run without an installation.  Of
 # course, many tests require a machine running Xen itself, and these are
 # handled elsewhere.
@@ -104,7 +111,7 @@
 # and place them in the install directory. 'make install' should then
 # copy them to the normal system directories
 .PHONY: world
-world:
+world: check
        $(MAKE) clean
        $(MAKE) kdelete
        $(MAKE) dist

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel