Re: [Xen-devel] [PATCH] yet another package check

[Brendan Cully <brendan@xxxxxxxxx>]

On Thursday, 14 December 2006 at 15:23, Jan Beulich wrote:
> >This is the adaption for -unstable:
> >
> >diff -r 360eb996fa38 tools/check/check_python
> >+++ b/tools/check/check_python  Thu Dec 14 15:31:18 2006 +0100
> >@@ -3,7 +3,7 @@
> > 
> > RC=0
> > 
> >-python -V 2>&1 | cut -d ' ' -f 2 | grep -q '^2.[2345]' || RC=1
> >+python -c 'import sys; sys.exit(sys.version_info[0] < 2 or 
> >sys.version_info[1] < 2);' || RC=1 
> > 
> > if test ${RC} -ne 0; then
> >        echo
> 
> What's wrong with using functions in shell scripts?

error () {
}

is a lot more portable than 

function error {
}

FWIW.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel