[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode function


  • To: "Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Fri, 01 Dec 2006 07:54:35 +0000
  • Delivery-date: Thu, 30 Nov 2006 23:54:38 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccUxNJKXbh+wUkjTq2sw7PZxoJSVQAWR8CC
  • Thread-topic: [Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode function

On 30/11/06 9:16 pm, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

> This patch fixes incorrect logic in the recently added
> xenoprofile_get_mode() function.
> On HVM guests the !guest_mode(regs) test will always succeed, so move
> the is_hvm_vcpu() test first.
> This change allows modes other than 2 to be returned properly for
> xenoprofile for HVM guests.
> 
> Signed-off-by: Tom Woller <thomas.woller@xxxxxxx>
> Please apply to xen-unstable.hg.

This is wrong. The actual problem is that you should be passing
guest_cpu_user_regs() to xenoprofile_get_mode(). I'll fix that.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.