[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline for too long.


  • To: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Mon, 27 Nov 2006 10:21:54 +0000
  • Delivery-date: Mon, 27 Nov 2006 02:21:58 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccSDdwbGnEGJX4BEduPjQAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline for too long.



On 24/11/06 13:10, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:

> After being offline for a long time, the softlockup  watchdog triggers
> a BUG() on our faces. This is expected, as in fact, we spent more than
> a fixed 10*HZ amount of time without touching the watchdog.
> 
> However, by inspecting the contents of RUNSTATE_offline, we can gain
> awareness of the fact, and do better than that. This patch fixes it.
> 
> Signed-off-by: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>

Would 'stolen' not be a good enough thing to test? Presumably this is really
just dealing with xm pause/unpause (a single long offline) so this simpler
fix would work just as well?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.