[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] HVM cleanups


  • To: "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Fri, 17 Nov 2006 08:30:55 +0000
  • Delivery-date: Fri, 17 Nov 2006 00:31:14 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccJoV4MxuRi2+t0S4ytjjt+U9eghwACMUsQAB0d0+AAAQYYBw==
  • Thread-topic: [Xen-devel] [PATCH] HVM cleanups

On 17/11/06 8:12 am, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> now in xen/arch/x86/hvm directory we have hvm.c, platform.c, io.c,
> intercept.c; I think these some of these file names are not clear, sometimes I
> don't remember which file a hvm function lives in :-(, maybe it's time to
> clean them, for example maybe it's better to name platform.c as mmio.c, and
> some functions need to be moved from one file to another, also we can merge
> some files.

I agree that this needs cleaning up at some point, as control flow seems to
jump randomly across these files. But I live in hope that the MMIO decoder
will die at some point soon and that should kill off much of io.c and
platform.c anyway. What about all the other stuff? Do you have a plan
already about: (a) what subsystems/functions we have to support; and (b)
what filenames you think they belong in? Renames are a pain for some people
so I'd like any rename to happen only once.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.