[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] inline VMX functions


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
  • Date: Mon, 13 Nov 2006 17:03:17 +0800
  • Delivery-date: Mon, 13 Nov 2006 01:03:55 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AccGzGxsIIVOm6GYQlqxIj8TgPNHxgAMGp1dAAEBseA=
  • Thread-topic: [Xen-devel] [PATCH] inline VMX functions

>
>Unless the function call is really hot (in an inner loop for example) I
>don't believe that the performance benefit of inlining is 
>measurable (or
>maybe even exists at all). Against that there are the 
>disadvantages that
>debugging from a backtrace becomes much more of a pain (especially that
>vmexit handler, which becomes *really* big!), and there's a 
>tendency for
>'inline' to spread around like a 'go faster' magic dust, applied to
>functions where it really doesn't help. So I'm moderately 
>inclined not to
>take the inlining bits of this patch unless you strongly disagree.
>

OK, let's not take it, such VMExits are small part of total VMExits.
-Xin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.