Re: [Xen-devel] [PATCH] [RESEND] remove redundent call to hvm_do_resume

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 22/10/06 22:38, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> Remove redundant call to hvm_do_resume.
> In this patch IO event channels in qemu are used for IO done
> notification only, so we can simplify the event checking handling in
> hvm_do_resume.
> Besides current intr notification from qemu is complete meanless,
> because eithor it's done with an IO event, or acturally do thing since
> the new xen consumed event channel, we will find a better way to
> implement that functionality.

I like avoiding hvm_do_resume() on every vm entry, so I took that part of
the patch. The change to ioemu was odd -- there are other places that set
send_event to 1 (the code that adds IRQs to the PIC IRR). We know that code
is somewhat broken for SMP guests, but you *do* need to notify Xen when
interrupts happen, right?

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel