[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [XEND] Remove hard tabs



Hollis Blanchard wrote:
On Sun, 2006-09-24 at 12:50 +0200, Molle Bestefich wrote:
Hollis Blanchard wrote:
Molle Bestefich wrote:
Hollis Blanchard:
[XEND] Remove hard tabs.
That's stupid, tabs are a relief to use when coding compared to spaces.
That's a separate conversation.
Seemed relevant since what you're doing is switching things originally
coded one way to use what *you* prefer, without changing the code at
all (right?).

No, actually, I prefer tabs. :) However, there were ~10 lines in that
file using tabs, with all the rest using spaces. In Python that's a more
serious offense than in other languages.

As it has been mentioned, whitespace is the right thing to do in python. It's not a point of debate.

Tab-width is interpreted as 8 in Python. This can lead to subtle bugs in code where people use text-editors with different width tabs. These are real bugs that have actually occurred in Xen before.

There have been big patches in Xend to globally remove tabs. Any time the creep back in, they ought to be removed.

For more info, see:

http://docs.python.org/ref/indentation.html

Regards,

Anthony Liguori


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.