[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value



Hi,

Do you have any comment?
If you have no comment, could you commit this patch?

http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00244.html

On <20060908.105047.77000778.kuwa@xxxxxxxxxxxxxx>,
 "KUWAMURA Shin'ya" said:
> 
> This patch adds the argument check of "--ms_per_sample" option. 
> 
> If a value of "--ms_per_sample" option is larger than a value of
> "--time" option, xenmon may generate no log file. So, too large
> "--ms_per_sample" should be treated as an error.
> 
> e.g. 
>   % xenmon.py --ms_per_sample=2000 -t 1 -n
>   usage: xenmon.py [options]
>   
>   xenmon.py: error: option --ms_per_sample: too large (> 1000 ms)
> 
> # Notice that a unit of "--time" is a second.
> 
> Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>

Best Regards,
-- 
  KUWAMURA Shin'ya

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.