[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] block_sync bugfix & cleanup


  • To: "Jun Koi" <junkoi2004@xxxxxxxxx>
  • From: "Andrew Warfield" <andrew.warfield@xxxxxxxxxxxx>
  • Date: Fri, 1 Sep 2006 13:28:16 -0700
  • Cc: Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>, jac90@xxxxxxxxx
  • Delivery-date: Fri, 01 Sep 2006 13:28:41 -0700
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=TboNWaSklNrcq8H0T0LMEWelBAb7OBrmHonG9+u1ksIrHTw00GwqPxc2q0P4Bys+17YejXCrQs8iNc0JvJTjxfjM1ZHdeKgIC+yxFKNSP/aDLo5oOjQPjDx5ld0Q/K0tU0eDpt/f1roq347bitv+3+Z30apwx94xWiEsB3LlFUE=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Hi Jun,

  The sync disk hasn't received a lot of use (it's quite slow) and is
intended mostly as a simpledemontrator of writing disk plugins.  I'm
happy to take cleanups to error handling code, but would rather that
they also fix the call in tapdisk to actually handle the error
properly -- returning BLKIF_RSP_ERROR to the frontend if the io can't
be issued for whatever reason.

  Whitespace fixes are fine, but lets do them all at once and in a
separate patch from bug fixes.  I can take a look at this for the
entirety of the user blktap code next week.

Thanks!
a.

On 9/1/06, Jun Koi <junkoi2004@xxxxxxxxx> wrote:
Hi Julian and Andrew,

This patch reindents some lines of block_sync.c and fixes a small bug.
Please apply.

Signed-off-by: Jun Koi <junkoi2004@xxxxxxxxx>




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.