[Xen-devel] Xen build with perf counters is broken

[Steve Dobbelstein <steved@xxxxxxxxxx>]

Compiling the hypervisor with performance counters fails.  If I do a
"perfc=y perfc_arrays=y make xen" I eventually get:

sysctl.c: In function ?do_sysctl?:
sysctl.c:124: error: ?XEN_SYSCTL_perfccontrol? undeclared (first use in
this function)
sysctl.c:124: error: (Each undeclared identifier is reported only once
sysctl.c:124: error: for each function it appears in.)
sysctl.c:126: error: expected ?)? before ?*? token
cc1: warnings being treated as errors
sysctl.c:127: warning: implicit declaration of function ?perfc_control?
sysctl.c:127: error: ?union <anonymous>? has no member named ?perfccontrol?
make[4]: *** [sysctl.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [/usr/src/xen/xen-unstable.hg-11257/xen/common/built_in.o]
Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/usr/src/xen/xen-unstable.hg-11257/xen/xen] Error 2
make[1]: *** [install] Error 2
make: *** [install-xen] Error 2

It appears that changeset 11257:86d26e6ec89b, which replaced the dom0_ops
hypercalls with new hypercalls, left the changes needed for the performance
counters half cooked.

Attached is a patch that gets the code to compile successfully.  It may not
be the correct implementation, so feel free to tweak as necessary.  A quick
test shows that I do get performance counter data from xenperf, so I
couldn't have been too terribly wrong. :)

Steve D.

(See attached file: perfc-fix.patch)
Signed-off-by: Steve Dobbelstein <steved@xxxxxxxxxx>

Attachment: perfc-fix.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel