[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [patch 5/6] frontend device shutdown


  • To: Gerd Hoffmann <kraxel@xxxxxxx>, Xen devel list <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Sat, 19 Aug 2006 13:52:24 +0100
  • Delivery-date: Sat, 19 Aug 2006 06:01:41 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcbDjlEYj4fi2S+BEdu36QANk04WTA==
  • Thread-topic: [Xen-devel] [patch 5/6] frontend device shutdown

On 17/8/06 3:03 pm, "Gerd Hoffmann" <kraxel@xxxxxxx> wrote:

> + int shutdown_in_progress;

Get rid of this field in your next patch.

The use in xenbus_client.c should go away because you should unconditionally
move to state XenbusStateClosed, fixing up backend drivers as necessary.

The use in netfront.c doesn't make much sense to me. Is it a side effect of
needing to move into state XenbusStateInitialised (which will be going
away)? I think we should be able to do without it, anyway (maybe a fix to
backend drivers will be required).

The use in blkfront.c can be replaced by a check of system_state (e.g.,
(system_state == SYSTEM_RUNNING)) as defined in linux/kernel.h.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.