[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: A random bug introduced in C/S 10918


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
  • Date: Tue, 15 Aug 2006 23:00:21 +0800
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 15 Aug 2006 08:04:16 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcbAZx4ugltCVnl8QUaZNyAwR4A5DwAC2eaqAAIpFDA=
  • Thread-topic: A random bug introduced in C/S 10918

>Try removing _PAGE_GLOBAL from line 117 of 
>arch/x86/x86_64/mm.c. Should be a
>bit more correct. ;-)
>

Yes, it works fine for me, patch as your instructions:

diff -r 7ff6020e4758 xen/arch/x86/x86_64/mm.c
--- a/xen/arch/x86/x86_64/mm.c  Thu Aug 03 15:02:34 2006 +0100
+++ b/xen/arch/x86/x86_64/mm.c  Tue Aug 15 22:57:48 2006 +0800
@@ -113,8 +113,7 @@ void __init paging_init(void)
             PAGE_HYPERVISOR);
         memset((void *)(RDWR_MPT_VIRT_START + (i <<
L2_PAGETABLE_SHIFT)), 0x55,
                1UL << L2_PAGETABLE_SHIFT);
-        *l2_ro_mpt++ = l2e_from_page(
-            pg, _PAGE_GLOBAL|_PAGE_PSE|_PAGE_USER|_PAGE_PRESENT);
+        *l2_ro_mpt++ = l2e_from_page(pg,
_PAGE_PSE|_PAGE_USER|_PAGE_PRESENT);
         BUG_ON(((unsigned long)l2_ro_mpt & ~PAGE_MASK) == 0);
     }


BTW, seems the definition of RO_MPT_VIRT_START is misleading, should be
RO_PMT_VIRT_START, also the comments around is incorrect.
-Xin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.