[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH][XEN] fix missing header and gcc warning





On 14/8/06 7:36 am, "Markus Armbruster" <armbru@xxxxxxxxxx> wrote:

>> -    memcpy(dp + op->dest.offset, sp + op->source.offset, op->len);
>> +    memcpy((void *)((ulong)dp + op->dest.offset),
>> +           (void *)((ulong)sp + op->source.offset),
>> +           op->len);
> 
> I find this needlessly ugly.  Why not just declare sp and dp char *?

That's what I checked in.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.