[Xen-devel] Re: [3/11] [NET] front: Stop using rx->id

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 27 Jul 2006, at 14:12, Herbert Xu wrote:

> Had we used the body of the second loop for the initial segment we 
> would
> end up wiping out the values of rx_skbs and grant_rx_ref when we do the
> assignments
>
>                 skb = np->rx_skbs[requeue_idx] = xennet_get_rx_skb(np, i);
>                 ref = np->grant_rx_ref[requeue_idx] = xennet_get_rx_ref(np, i);
>
> because for the initial segment requeue_idx is always the same as i.
But wouldn't the xennet_get_* functions wipe the entries, only to be 
immediately filled in again by the assignment to e.g., 
np->rx_skbs[requeue_idx], so it would all work out okay (except a 
needless wipe-then-rewrite)?
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel