RE: [Xen-devel] Xen scheduling bug?

["Nakajima, Jun" <jun.nakajima@xxxxxxxxx>]

Looks like it should be XEN_UNBLOCK_EVENTS.

Jun
---
Intel Open Source Technology Center 

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Stephen C.
Tweedie
Sent: Saturday, July 15, 2006 8:38 AM
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Xen scheduling bug?

Hi all,

The arch/x86_64/kernel/entry-xen.S linux-2.6-xen.hg contains:

sysret_careful:
        CFI_RESTORE_STATE
        bt $TIF_NEED_RESCHED,%edx
        jnc sysret_signal
        XEN_BLOCK_EVENTS(%rsi)          <<<<<<<<<<<<<<
        pushq %rdi
        CFI_ADJUST_CFA_OFFSET 8
        call schedule
        popq  %rdi
        CFI_ADJUST_CFA_OFFSET -8
        jmp sysret_check
sret_careful:
The equivalent non-Xen chunk is:

sysret_careful:
        CFI_RESTORE_STATE
        bt $TIF_NEED_RESCHED,%edx
        jnc sysret_signal
        TRACE_IRQS_ON
        sti                             <<<<<<<<<<<<<<
        pushq %rdi
        CFI_ADJUST_CFA_OFFSET 8
        call schedule
        popq  %rdi
        CFI_ADJUST_CFA_OFFSET -8
        jmp sysret_check

Note the marked lines --- Xen is turning irqs _off_ at this point, when
non-Xen is turning them on.  I just noticed it when merging the
irqtracing code.

Bug?

--Stephen



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel