[Xen-devel] Re: [XenPPC] [rfc][patch][linux] ioctl32() compat plumbing for xen calls

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Jul 13, 2006, at 12:42 PM, Hollis Blanchard wrote:

> That's a curious use of CONFIG_XEN_PRIVCMD... I think it would make  
> more
> sense to use it in the parent directory:
I agree, the  dir fix below should go in independent to the  
CONFIG_COMPAT part.
> diff -r 72c8bc5d88f4 drivers/xen/Makefile
> --- a/drivers/xen/Makefile      Thu Jun 29 13:04:30 2006 -0400
> +++ b/drivers/xen/Makefile      Thu Jul 13 11:33:30 2006 -0500
> @@ -1,7 +1,7 @@ obj-y   += core/
>  obj-y  += core/
>  obj-y  += console/
>  obj-y  += evtchn/
> -obj-y  += privcmd/
> +obj-$(CONFIG_XEN_PRIVCMD) += privcmd/
>  obj-y  += xenbus/
>
>  obj-$(CONFIG_XEN_UTIL)                 += util.o
>
> diff -r 72c8bc5d88f4 drivers/xen/privcmd/Makefile
> --- a/drivers/xen/privcmd/Makefile      Thu Jun 29 13:04:30 2006 -0400
> +++ b/drivers/xen/privcmd/Makefile      Thu Jul 13 11:37:18 2006 -0500
> @@ -1,2 +1,3 @@
>
> -obj-$(CONFIG_XEN_PRIVCMD)      := privcmd.o
> +obj-y := privcmd.o
> +obj-$(CONFIG_COMPAT) += privcmd.o
>
>
> There's no point in recursing into the directory in the first place if
> the config variable isn't set...
>
> --
> Hollis Blanchard
> IBM Linux Technology Center
>
>
> _______________________________________________
> Xen-ppc-devel mailing list
> Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ppc-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel