[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] e820.c : why char* ? (2nd try)



On Thu, 2006-06-29 at 11:36 +0200, PUCCETTI Armand wrote:
> In function
> 
> sanitize_e820_map(struct e820entry * biosmap, char * pnr_map)
> 
> of file e820.c, the last argument is treated as an integer, but when 
> compiling with gcc it belongs to [-128,127].

This is not a Xen specific issue. On native the value comes from the
BIOS and is a single byte, hence the type. Xen uses the same function.

I don't think it is possible for there to ever be more than 127 entries
in an e820 map so other than potentially wasting a couple of entries in
the tables I don't see a problem.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.