Re: [Xen-devel] [PATCH][RESEND]Xenoprof passive domain support

["Ray Bryant" <raybry@xxxxxxxxxxxxxxxxx>]

On Tuesday 27 June 2006 00:55, Yang, Xiaowei wrote:
> Keir,
> After several discussions with Renato, I remade the patch, which is
> against c/s 10428. The main functionality remains the same, while it
> takes more care of passive domain status cleanup, adopts a more
> efficient lockup mechanism, a more consistent interface which is used by
> active domain, and does some improvements of code style.
>
> Thanks,
> Xiaowei

Xiaowei,

Hmmm... When I apply your patch to 10428, then try to compile 
linux-2.6.16.13-xen, it fails with the following:

  CC      arch/x86_64/oprofile/../../i386/oprofile/xenoprof.o
arch/i386/oprofile/xenoprof.c: In function `xenoprof_handle_passive':
arch/i386/oprofile/xenoprof.c:160: error: `IGNORED_PC' undeclared (first use 
in this function)
arch/i386/oprofile/xenoprof.c:160: error: (Each undeclared identifier is 
reported only once
arch/i386/oprofile/xenoprof.c:160: error: for each function it appears in.)
arch/i386/oprofile/xenoprof.c:160: error: `CPU_MODE_PASSIVE_START' undeclared 
(first use in this function)
arch/i386/oprofile/xenoprof.c:162: error: `CPU_MODE_PASSIVE_STOP' undeclared 
(first use in this function)
arch/i386/oprofile/xenoprof.c: At top level:
arch/i386/oprofile/xenoprof.c:449: error: unknown field `set_passive' 
specified in initializer
arch/i386/oprofile/xenoprof.c:449: warning: initialization from incompatible 
pointer type
make[1]: *** [arch/x86_64/oprofile/../../i386/oprofile/xenoprof.o] Error 1

Any suggestions?
-- 
Ray Bryant
AMD Performance Labs                   Austin, Tx
512-602-0038 (o)                 512-507-7807 (c)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel