Re: [Xen-devel] [PATCH] xc_evtchn_*() interfaces

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 14 Jun 2006, at 20:44, John Levon wrote:

> > > No longer open the device as non-blocking: all reads immediately 
> > > follow
> > > a select() on the device indicating it's ready to read.
> > Why change this?
> Because not all users specified O_NONBLOCK, so to keep the exact same
> code would mean complicating the API a little bit. As there is no 
> extant
> code that actually takes advantage of O_NONBLOCK, it's pointless having
> the extra code (note that xenstore would actually die if it ever got
> EAGAIN...)
Okay, that makes sense.

Looking at the patch, one nit I have is that the 'event-channel handle' 
(xce_handle) abstraction is broken by the fact that interface users add 
the handle to fd sets. Either we should just own up to the fact that 
xce_handle really is just xce_fd, and thus call it that, or else add a 
xc_evtchn_fd() interface for getting a pollable fd from a xce_handle. 
Do you have a preference?
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel