Re: [Xen-devel] [PATCH][NET] front: cleanup some error paths

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 8 Jun 2006, at 20:22, Chris Wright wrote:

> There's a small leak on a couple error paths in setup_device().
> While there rearrange the ring setup order slightly to simplify error
> path since netif_free() will cleanup once ring_ref is valid.  And use
> get_zeroed_page() instead of __get_free_page()/memset().  Handle error 
> if
> bind_evtchn_to_irqhandler() fails, as bad info->irq value is likely to
> cause oops later.  In create_device(), gnttab_free_grant_references()
> is accidentally called twice on tx_head during cleanup from failed
> gnttab_alloc_grant_references() on rx_head, which could corrupt
> gnttab_free_count.
Applied, but I don't think it's a complete fix. For example, shouldn't 
txs/rxs be freed if bind_evtchn_to_irqhandler() fails? There should 
probably be more test-and-free cases on the fail path.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel