Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 19 May 2006, at 22:08, Ryan Harper wrote:

> I've got the ACPI numa.c parser function using
> linux/arch/x86_64/mm/srat.c almost entirely unmodified.
> linux/arch/x86_64/mm/numa.c was gutted retainly only the calls between
> itself and srat.c.  I kept the memnodemap which has a nice 
> phys_to_nid()
> function.  There is still some cleanup to do, but I'd like some 
> feedback
> on what I used and didn't.
>
> I didn't bring in mmzone.h but I did pull a few ideas and defines from
> there.  We have a simple node_data structure with start_pfn,
> spanned_pages and node_id.
I hope Andi will give his opinion, but one thing I spotted immediately 
is that there are plenty of unnecessary diffs against the original 
files. For example, you don't need to remove __read_mostly: we don't 
implement it (yet) but we do define that attribute to nothing so it 
doesn't hurt to keep it in the source files. And why change printk() to 
DPRINTK(): if the original author thinks it's useful enough to always 
print out that's good enough for us, and it keeps the diff smaller. 
These are just a couple of examples: there might be others. These are 
only minor and easily fixed nits, of course!
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel