[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races


  • To: "Markus Armbruster" <armbru@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Santos, Jose Renato G" <joserenato.santos@xxxxxx>
  • Date: Mon, 15 May 2006 14:51:44 -0700
  • Delivery-date: Mon, 15 May 2006 14:52:09 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcZ4VAftb5YJE269QHyM6dOspPHCJQAFEC0Q
  • Thread-topic: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races

 

>> > Sorry, didn't mention this earlier.  Please use new mutex 
>> code here, 
>> > smth like:
>> >
>> > s/DECLARE_MUTEX(adom_sec)/DEFINE_MUTEX(adomain_mutex)/
>> > s/down(&adom_sem)/mutex_lock(&adomain_mutex)/
>> > s/up(&adom_sem)/mutex_unlock(&admoain_mutex)/
>> >
>> > thanks,
>> > -chris
>> 
>> What about buffer_sem in drivers/oprofile/event_buffer.c and 
>> start_sem in drivers/oprofile/oprof.c?  Want me to submit a 
>> patch to convert all three?
>> 

   I think we should minimize changes to generic oprofile code
   (in drivers/oprofile) to minimize divergence from main stream linux.
   For this reason I don't think we should touch buffer_sem and
   start_sem.

   Renato

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.