Re: [Xen-devel] [RFC][PATCH] allow dom0 to power off machine using ACPI on shutdown.

[Muli Ben-Yehuda <mulix@xxxxxxxxx>]

On Thu, Apr 06, 2006 at 07:58:50PM +0100, Harry Butterworth wrote:

> The kernel is for both dom0 and domU.  I think in the domU case the
> hypervisor call is the correct mechanism to power off the virtual
> machine.

I meant in the dom0 case, of course.

> > > I thought this kind of solution was better than trying to import a lot
> > > more ACPI cruft into Xen.  Any thoughts?
> > 
> > I think you want kernel_power_off() here, which should do the right
> > thing for all architectures.
> 
> No. kernel_power_off is currently already being called and doesn't work
> because it calls machine_power_off which in current unstable calls the
> hypervisor which doesn't power off the hardware.
> 
> My patch modifies machine_power_off to call the native pm power off if
> present (i.e. if dom0) or the hypervisor if not (i.e. domU).

I see... Xen provides its own machine_power_off() in
drivers/xen/core/reboot.c. If we go with dom0 shutting the machine
down, the right fix would be to get rid of it and / or make it call
the arch specific machine_power_off().

Cheers,
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel