[Xen-devel] Re: [RFC, PATCH 5/24] i386 Vmi code patching

[Andi Kleen <ak@xxxxxxx>]

On Monday 13 March 2006 19:02, Zachary Amsden wrote:
> The VMI ROM detection and code patching mechanism is illustrated in
> setup.c.  There ROM is a binary block published by the hypervisor, and
> and there are certainly implications of this.  ROMs certainly have a
> history of being proprietary, very differently licensed pieces of
> software, and mostly under non-free licenses.  Before jumping to the
> conclusion that this is a bad thing, let us consider more carefully
> why hiding the interface layer to the hypervisor is actually a good
> thing.

How about you fix all these issues you describe here first 
and then submit it again?

The disassembly stuff indeed doesn't look like something
that belongs in the kernel.

-Andi


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel