[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] >1 IP address on eth0 causes hotplug script failure

  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: James Dykman <dykman@xxxxxxxxxx>
  • Date: Wed, 22 Feb 2006 15:47:38 -0500
  • Delivery-date: Wed, 22 Feb 2006 20:47:59 +0000
  • Importance: Normal
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Sensitivity:

Adding a second IP address onto eth0 causes the vif-* hotplug scripts to 
fail: ip_of() is returning a LIST of IP addresses, one per line.
The vif-scripts attempt to use the list where single addresses ought to 
be, with predictable results. This patch changes ip_of() to return
the first address in the list, which seems to be the first one configured.

This came up while testing the patch for the checksum errors on IPSEC 
tunnels. I added an IP address for the tunnel on eth0 and
domUs wouldn't start anymore. 

Since this changes vif-common.sh, I ran xm-test using -bridge, -route, and 
-nat scripts, each with 1 and 4 IP addresses on eth0.

Signed-off-by: Jim Dykman <dykman@xxxxxxxxxx>

diff -r 57e6d7218427 tools/examples/vif-common.sh
--- a/tools/examples/vif-common.sh      Fri Feb  3 18:45:14 2006
+++ b/tools/examples/vif-common.sh      Wed Feb  8 16:08:56 2006
@@ -125,7 +125,7 @@
 function ip_of()
-  ip addr show "$1" | awk "/^.*inet.*$1\$/{print \$2}" | sed 's,/.*,,'
+  ip addr show "$1" | awk "/^.*inet.*$1\$/{print \$2}" | sed 's,/.*,,' | 
head -1


Attachment: vifcommon.patch
Description: Binary data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.