Re: [Xen-devel] [PATCH] make x86_64 vcpu hotplug work like i386

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 8 Feb 2006, at 21:43, Ryan Grimm wrote:

> the critical difference is that play_dead in arch/i386/process-xen.c 
> and
> arch/x86_64/process-xen.c differ.  the i386 version makes a VCPUOP_down
> call to the hypervisor while the x86_64 version schedules a
> SCHEDOP_yield among other things.
>
> plopping the i386 version (patch below) into x86_64/process-xen.c makes
> hotplugging in x86_64 behavior like i386.  does anyone know why the
> x86_64 play_dead function is in the current state?
Noone bothered to keep it in sync with the i386 version (and the 
'common' hotplug changes in drivers/xen/core/smpboot.c). That would 
probably be my fault. :-)
I've checked in a fixed up patch that still calls idle_task_exit(), and 
adds a call to it in i386's play_dead function, and also enables 
HOTPLUG_CPU in our x86_64 defconfigs.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel