[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] Pin vcpu for VMX domain

        Just some curious question.

Keir Fraser wrote:
> On 8 Feb 2006, at 09:28, Jiang, Yunhong wrote:
> You don't need to __vmpclear at the time the affinity is changed. You
> can still do it from within arch_vmx_do_resume() -- it is valid to
> call smp_call_function() there. That avoids having yet another HVM
> function, and avoids calling yet another arch_* function from common
> code. 
Good point. Do u mean we check v->arch.hvm_vmx.launch_cpu with
 v->processor in arch_vmx_do_resume and send IPI if they are not equal?
If yes, is it worth to exchage common code change with the frequent
at every resume?
> Rather than calling vmx_remove_timers() from your SMP call function,
> can you not just call it from vmx_reinstall_timers()? You explain why
Sure will look into details.
Do u mean removing ac_timer on remote physical processor? Just a little
bit worry about the corner case. 
> the pit and hlt timers do not need to be re-activated in
> vmx_reinstall_timer() -- what about the APIC timer?
Oo, thanks, a mistake here.

> There's no need to check active_timer() before calling stop_timer() --
> stop_timer does the check for you.
Yes, sir!

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.