[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI Backend/Frontend



Dave,

Thanks for spotting that. I believe those were incorrectly moved when I
was correcting some coding style issues. I'm preparing a new patch
against xen-unstable (to include the recent Linux 2.6.16-rc2 import into
the tree) which I hope to post in the next few days. I'll include this
fix in that patch.

Ryan

On Mon, 2006-02-06 at 13:45 -0500, Dave Thompson (davetho) wrote:
> Ryan,
> 
> I found a bug in this patch.  The function pciback_publish_pci_roots()
> added in the file linux-2.6-xen-sparse/drivers/xen/pciback/passthrough.c
> sets the local variables domain and bus using the dev_entry pointer
> which is uninitialized at this point.  The two lines which set these
> variables should be moved down so that they are within the
> list_for_each_entry loop.
> 
> FYI,
> Dave Thompson
> 
> > -----Original Message-----
> > From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> > [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Ryan
> > Sent: Monday, January 30, 2006 7:24 AM
> > To: xen-devel
> > Subject: [Xen-devel] [PATCH][2/4] PCI Driver Domains: PCI 
> > Backend/Frontend
> > 
> > This patch contains the PCI backend and frontend drivers for Linux
> > 2.6.12. There are a couple of compile-time options in the backend and
> > frontend although the defaults should be sufficient to get you up and
> > running.
> > 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.