[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] cset 8690 blk driver regression

Hi Steven,

  I'm seeing a regression on ia64 with this chunk of cset 8690:

--- a/xen/common/grant_table.c  Fri Jan 27 20:38:55 2006
+++ b/xen/common/grant_table.c  Fri Jan 27 20:57:07 2006
@@ -522,9 +522,7 @@
         ASSERT(d->grant_table != NULL);
         (void)put_user(GNTST_okay, &uop->status);
         for ( i = 0; i < op.nr_frames; i++ ) {
-            mfn = gnttab_shared_mfn(d, d->grant_table, i);
-            if (shadow_mode_translate(d))
-                mfn = __mfn_to_gpfn(d, mfn);
+            mfn = __mfn_to_gpfn(d, gnttab_shared_mfn(d, d->grant_table, i));
             (void)put_user(mfn, &op.frame_list[i]);

With this chunk, my domU no longer finds it's block device and fails to

VFS: Cannot open root device "hda1" or unknown-block(0,0)
Please append a correct "root=" boot option
Kernel panic - not syncing: VFS: Unable to mount root fs on

Everything appears fine if I revert it.  Is this an intentional change?
It appears to be more of a functional change than the check-in comment
for this changeset would imply.  Thanks,


Alex Williamson                             HP Linux & Open Source Lab

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.