[Patch] Re: [Xen-devel] [RFC] Is grant_read() runnable?

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, all

I'm sorry for poor English.
I rewrite my mail.

Even if/proc/xen/grant is read, nothing is displayed probably. 
I comment to the following sources. 

So I make patch. Is my patch correct?

----------------------
static int
grant_read(char *page, char **start, off_t off, int count, int *eof,
           void *data)
{
        int             len;
        unsigned int    i;
        grant_entry_t  *gt;

        gt = (grant_entry_t *)shared;
        len = 0; 

        for (i = 0; i < NR_GRANT_ENTRIES; i++) {
                if (len > (PAGE_SIZE - 200)) {    <---- always FAIL
                        len += sprintf( page + len, "Truncated.\n");
                        break;
                }
        }

        if (gt[i].flags) {   <--- always gt[NR_GRANT_ENTRIES].flags
                len += sprintf(page + len,
                               "Grant: ref (0x%x) flags (0x%hx) "
                               "dom (0x%hx) frame (0x%x)\n", 
                               i,
                               gt[i].flags,
                               gt[i].domid,
                               gt[i].frame );  <--- So This sprintf doesn't 
make sence almost.
        }

        *eof = 1;
        return len;
}


Best Regards,

Akio Takebe

>Hi, all
>
>I think grant_read() is not runnable.
>" (len > (PAGE_SIZE - 200)) " is not entered into if sentence 
>becase of len=0.
>So i always equal NR_GRANT_ENTRIES.
>
>Is the below patch correct?
>Please comment.
>
>Best Regards,
>
>Akio Takebe
>

Attachment: grant_read.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel