[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] cdb: split cdb into arch independet/dependet part

On 14 Jan 2006, at 01:53, Isaku Yamahata wrote:

+/* Append this to the declaration of any function needed to be used by
+ * the gdb stub.  Any functions marked with this will not be allowed
+ * to have a breakpoint set in them. */
+#define __gdbstub __attribute__((section(".gdbstub.text")))

These make sense if we want to avoid setting a breakpoint in GDB stub
code or code called by the GDB stub, such as serial output. However,
these symbols aren't currently used. (You probably inherited this from
the PPC stub.) At least it's worth a TODO comment, possibly in
gdb_cmd_write_mem(): we shouldn't be writing to memory between those
two symbols.

added __gdbstub_text_start, __gdbstub_text_end declarations and
a comment above gdb_cmd_write_mem()

Is this really worthwhile? The gdbstub will be using calling functions outside this range, so it's not a comprehensive solution for disallowing breakpoints in gdb mode. For that I think you'd need to clear all breakpoints on entry to gdbstub and re-set them on exit.

I'd prefer to avoid extra section directives unless they're clearly useful.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.