[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] nmi_count in common code?

  • To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
  • Date: Fri, 13 Jan 2006 13:09:18 -0800
  • Delivery-date: Fri, 13 Jan 2006 21:16:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcYYhZ3i5koMFZiZSDWo2+L950YLvg==
  • Thread-topic: nmi_count in common code?

Ian C's recent xen-unstable cset (8585), put some archdep
code involving nmi_stats in keyhandler.c.  While
there happens to be an easy workaround on ia64 for this
and -- in this particular case -- there might be some
use to having a similar key on ia64 (not sure on ppc?),
there are undoubtedly some archdep issues here that
probably ought to be managed in archdep code.

Perhaps it is time to add an arch_initialize_keytable()
in archdep code and then move the new do_nmi_stats
with that into a new arch/XXX/keyhandler.c?

And, please, y'all be careful out there when adding
code to common files!


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.