[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fixing bug/typo in main.py

On Wed, Jan 11, 2006 at 04:21:21PM +0900, Yoshinori Katase wrote:

> This patch fixes a typo of main.py.
> 1.xm reboot help is shown only 3 arguments.

What you've done here isn't right.  xm reboot is redirected through xm
shutdown, but that's just a messy implementation detail.  xm shutdown -H means
shutdown and don't restart regardless of configuration to the contrary -- xm
reboot -H therefore does not make any sense.  xm shutdown -R is exactly the
same as xm reboot, and so xm reboot -R does not make any sense either.

We ought to change the arg_check for xm_reboot to allow a maximum of 3
arguments, but better would be to rewrite shutdown.py so that the handling of
the call to the server was separate from the argument handling and this mess
was sorted out properly.  Any volunteers?



Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.