Re: [Xen-devel] pfn_pte/pfn_pmd

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Gerd Knorr <kraxel@xxxxxxx> 21.12.05 15:25:56 >>>
>> I still wonder, however, whether the BUG()/panic() in PAE's
pfn_pmd()
>> couldn't be removed...
>
>Wonder why it is still in there though, seems pfn_pmd() is never ever

>used, checking code ...
>
>Ok, seems they are needed for 2M/4M pages, we don't support these 
>anyway, so BUG()'ing in case this is called looks perfectly fine.

I was about to think so, too, but I wasn't able to prove that the code
in arch/i386/mm/init-xen.c that uses it (and that is conditional upon
cpu_has_pse) can't get executed. Specifically, I missed
include/asm-i386/mach-xen/setup_arch_post.h clearing X86_FEATURE_PSE...


>The panic msg probably should be changed to something more reasonable,

>such as "Huh? Who tried to use 2M pages?" maybe ;)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel