Re: [Xen-devel] [PATCH] [XM-TEST] Add support for VMX guests in xm-test

[Daniel Stekloff <dsteklof@xxxxxxxxxx>]

On Fri, 2005-12-09 at 11:17 +0000, Ewan Mellor wrote:
> On Wed, Dec 07, 2005 at 02:04:38PM -0800, Daniel Stekloff wrote:
> 
> > 
> > Here's a patch to add initial support for vmx guests in xm-test. This
> > patch applies to changeset 8272:b215584242c4.
> 
> I've applied this.  I would prefer it in the future if you could separate out
> unrelated changes into different patches.  For example, you have removed the
> unused __randomize facility from XmTestDomain with this patch.  Removing it is
> a useful thing to do, and appreciated, but it's not related to VMX guest
> support, so it would be better if you could provide such things as separate
> patches in the future.



Yes, I should have done that. Sorry...



> That said, VMX support for xm-test is a good idea, and your work is gratefully
> received.
> 
> > I've run it on both vmx and non-vmx guests. I got the following report
> > for running with vmx enabled:
> > 
> > Xm-test execution summary:
> >   PASS:  69
> >   FAIL:  23
> >   XPASS: 0
> >   XFAIL: 1
> 
> Do we have an idea as to the nature of these failures?  Are these things that
> will never be testable or implementable due to the nature of VMX domains, or
> are these failures, plain and simple?


Some of the tests fail because they aren't appropriate for full virt
domains. These will need to be edited to check to see if VMX is enabled
or not. 

Other tests aren't supported yet because the functionality hasn't been
implemented. These too could be SKIP'ed. 

And, I imagine there are some that are simple failures.

I need to take a closer look at the tests themselves, now that it's at
least running for vmx guests. 

Thanks,

Dan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel