[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] Some "make check" tests for xen/common



Hi Tony,

I've been trying out the make check/fullcheck and I'm very impressed! I hope it gets pulled into the tree soon.

Two suggestions though, for patches this large, it would help to either attach it to the original mail or provide a url to it. inlining is nice for review but a pain to pull out and apply to a tree.

Also, with the latest unstable (8311:53cff3f88e45) the patches fail to build (on xen/common/test/test_event_channel.c) because it cannot find the include file <public/event_channel.h> in the #include "../event_channel.c". I was able to work around this by adding -I../../include to the build rule in the Makefile.

Otherwise, this stuff rocks!

Regards,

Anthony Liguori

Tony Breeds wrote:

Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>

----- Forwarded message from Rusty Russell <rusty@xxxxxxxxxxxxxxx> -----

To: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Subject: [PATCH 3/3] Some "make check" tests for xen/common
Date: Fri, 09 Dec 2005 16:47:43 +1100

Some of these tests could probably be improved, but this is a first cut.
Not all the files are tested yet, just enough to know we're on the right
track.

Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.