[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] udev path failure can fail test incorrectly


  • To: xen--devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Nivedita Singhvi <nsnix@xxxxxxxxxxx>
  • Date: Sun, 13 Nov 2005 22:11:11 -0800
  • Delivery-date: Mon, 14 Nov 2005 06:14:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

This cleans up an install issue for udev.

Signed-off-by: Nivedita Singhvi (niv@xxxxxxxxxx)

# HG changeset patch
# User nivedita@phaedrus
# Node ID d46b43fb84846e15941a7a58c37ca1373918e464
# Parent  995e94c4802e5c0376b0483f3b2473a8f7d7808e
If /sbin/ isn't in path, install.sh will erroneously fail
and won't install udev rules in all the cases it should.

diff -r 995e94c4802e -r d46b43fb8484 install.sh
--- a/install.sh        Fri Nov 11 18:11:13 2005
+++ b/install.sh        Mon Nov 14 05:59:48 2005
@@ -27,7 +27,7 @@
 cp -fdRL $src/etc/init.d/* $dst/etc/init.d/
 echo "All done."

-if [ -x /sbin/udev ] && [ ! -z `udev -V` ] && [ `/sbin/udev -V` -ge 059]; then
+if [ -x /sbin/udev ] && [ ! -z `/sbin/udev -V` ] && [ `/sbin/udev -V` -ge 059 
]; then
   cp -f $src/etc/udev/rules.d/*.rules $dst/etc/udev/rules.d/
 else
   cp -f $src/etc/hotplug/*.agent $dst/etc/hotplug/


# HG changeset patch
# User nivedita@phaedrus
# Node ID d46b43fb84846e15941a7a58c37ca1373918e464
# Parent  995e94c4802e5c0376b0483f3b2473a8f7d7808e
If /sbin/ isn't in path, install.sh will erroneously fail
and won't install udev rules in all the cases it should.

diff -r 995e94c4802e -r d46b43fb8484 install.sh
--- a/install.sh        Fri Nov 11 18:11:13 2005
+++ b/install.sh        Mon Nov 14 05:59:48 2005
@@ -27,7 +27,7 @@
 cp -fdRL $src/etc/init.d/* $dst/etc/init.d/
 echo "All done."
 
-if [ -x /sbin/udev ] && [ ! -z `udev -V` ] && [ `/sbin/udev -V` -ge 059 ]; then
+if [ -x /sbin/udev ] && [ ! -z `/sbin/udev -V` ] && [ `/sbin/udev -V` -ge 059 
]; then
   cp -f $src/etc/udev/rules.d/*.rules $dst/etc/udev/rules.d/
 else
   cp -f $src/etc/hotplug/*.agent $dst/etc/hotplug/
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.