[Xen-devel] write_dev() limitation to 8bit minors

[Kurt Garloff <garloff@xxxxxxx>]

Hi,

in /etc/xen/scrips/block: write_dev(), there is

  major=$(stat -L -c %t "$1")
  minor=$(stat -L -c %T "$1")
  pdev=$(printf "0x%02x%02x" 0x$major 0x$minor)

Now, major numbers in Linux-2.6 are 12 bits and minors are 20 bits.
Look at e.g. /dev/sdsr
f52:/dev # stat -L -c %T /dev/sdsr
1f0

So, I would suggest to change this to 
  printf "0x$03x%05x" 0x$major 0x$minor
to generate a 32bit devno.

Comments?
-- 
Kurt Garloff, Director SUSE Labs, Novell Inc.

Attachment: pgpvwGikq7mxs.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel