[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] network-bridge script support for multipleexternal interfaces

Ian Pratt wrote:
I'd settle for being able to specify:

(network-script "network-bridge netdev=eth0 bridge=xenbr0
virtnum=0","network-bridge netdev=eth1 bridge=xenbr1 virtnum=1")

Thus far I haven't done any messing with xend's code, and am not entirely sure I want to. This patch was intended *only* to include an updated helper, such that xend could later be extended by someone else to actually call that helper multiple times. Personally, to call the helper more than once, I've just written some new init scripts.

I'm willing to consider poking at xend, but *only* if someone who actually owns it says "okay, I'll merge a patch that does that if you implement it *like so*". Even if that means I'm doing more work to do it the maintainer's way, having specs from upstream means there's a much better chance of what I'm doing actually getting merged.

[not totally convinced about the naming of virtnum. vifnum?]

I agree that vifnum is better.

[What's the correct sxp syntax for specifying a list of strings?]

If they're being adequately lispy and my memory doesn't deceive me, the strings are just separated by spaces... as in (foo "bar" "baz" "qux") <to call foo w/ arguments bar, baz and qux>, '("foo" "bar" "baz") <to return a list with foo, bar and baz as contents>, or such.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.