[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/2] Change xs_read_watch interfaces to support variable arguments



I should mention that I ran the xenstore testsuite (which rocks btw) and tested the block devices and network devices. I haven't tested blktap and vtpm but the changes are identical (and I don't have any test cases for those).

Regards,

Anthony Liguori

Anthony Liguori wrote:

The following set of changes modify the read_watch interface in userspace and in the kernel to support variable arguments. This is in preparation for adding domid to @{introduce,release}Domain watches. This will allow backends to automatically reap on domain destruction which should eliminate a large number of the zombie problems we're having on domain destruction since Xend no longer plays a role in freeing that memory.

The interface for read_watch is now consistent between userspace and kernel space. It's modelled after xs_read_directory. The returned array is indexable via XS_WATCH_* macros.

While slightly awkward, IMHO it seems like the cleanest and most flexible option of the proposed interfaces.

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>

Regards,

Anthony Liguori

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.