[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] xend - Have parseConfig check configuration options
This patch adds a check in parseConfig() to see if certain config options are valid, it sets defaults if they aren't. I realize that some of these defaults are set by xm - like "name". I think, however, it's a good idea for xend to check too. The recent bug 246 was solved first by putting a check in initDomain to see if "cpu" was None and then by only using "cpu" if there's a value. http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=246 Currently, the configuration options are dealt with in xm and then in different areas within xend. Shouldn't xend check for options and assign default values in one spot for easy maintenance? Shouldn't it check when it runs parseConfig? Also, it's possible for get_cfg(), which is in parseConfig(), to return None for some options that aren't defined in the config file - like "cpu". The "if conv and not val is None:" check won't hit val == None and then get_cfg() returns val. I will look at making the options consistent, if this is agreeable. Signed-off-by: Daniel Stekloff <dsteklof@xxxxxxxxxx> Attachment:
parseConfig_check_options.patch _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |