[Xen-devel] Re: [Xen-changelog] Deal with domain info going away (handle new error path introduced by

[Sean Dague <sean@xxxxxxxxx>]

Just as a quick nag, it would be nice if this patch had come across
xen-devel *before* being checked in, instead of afterwards.  ;)  

The catch happened pretty quickly on the changelog (thanks Dan), but it
would still have been nice to catch it before it broke anyone.

        -Sean

On Thu, Sep 15, 2005 at 05:08:14PM +0100, Steven Hand wrote:
> 
> >On Thu, 2005-09-15 at 04:14 +0000, Xen patchbot -unstable wrote:
> >> # HG changeset patch
> >> # User shand@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> >> # Node ID bd477fcd32aba8a3196873b702ae6ea0d8a7e43b
> >> # Parent  36f8c5900e8646b0465d92d602bd07f3d3b5a966
> >> Deal with domain info going away (handle new error path introduced by 
> >> cset 6828). Believe Dan Smith is working up a more comprehensive patch.
> >> 
> >> Signed-off-by: Steven Hand <steven@xxxxxxxxxxxxx>
> >> 
> >> diff -r 36f8c5900e86 -r bd477fcd32ab 
> >> tools/python/xen/xend/XendDomainInfo.py
> >> --- a/tools/python/xen/xend/XendDomainInfo.py      Thu Sep 15 01:46:40 200
> 5
> >> +++ b/tools/python/xen/xend/XendDomainInfo.py      Thu Sep 15 04:12:54 200
> 5
> >> @@ -353,7 +353,12 @@
> >>      def update(self, info=None):
> >>          """Update with  info from xc.domain_getinfo().
> >>          """
> >> -        self.info = info or dom_get(self.domid)
> >> +        if info:
> >> +            self.info = info
> >> +        else:
> >> +            di = dom_get(self.domid)
> >> +            if not di:
> >> +                return 
> >
> >
> >
> >Um.... shouldn't there be a "self.info = di" somewhere?
> 
> Oops - yes. 
> 
> cheers,
> 
> S.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 

-- 
__________________________________________________________________

Sean Dague                                       Mid-Hudson Valley
sean at dague dot net                            Linux Users Group
http://dague.net                                 http://mhvlug.org

There is no silver bullet.  Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________

Attachment: pgpVoS9kk7w9n.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel