[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] Add timeout to xenconsole to fix race condition in xm create -c


  • To: "Anthony Liguori" <aliguori@xxxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
  • Date: Tue, 30 Aug 2005 22:54:31 -0700
  • Delivery-date: Wed, 31 Aug 2005 05:52:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcWtra+UhOc3BNWHQPeKDu8OxKjwMgAQmVRA
  • Thread-topic: [Xen-devel] [PATCH] Add timeout to xenconsole to fix race condition in xm create -c

Anthony Liguori wrote:
> This should address the problems people are having now.
> 
Anthony, Hi

It cleanly fixed the problem I had. Thanks a lot for the quick fix!

> Wait a little bit for tty to appear.  There is a race condition that
> occurs after xend creates a domain.  Since no event triggers consoled
> to re-examine existing domains, we'll often not see the new pty by
> the time we're here.  Since consoled sleeps for 2 second periods, a 5
> second timeout should keep us covered.
> 
> A xenstore watch isn't much better since we don't want to block
> forever if given an invalid domain or worse yes, a domain that
> someone else has connected to.
> 
> Signed-off-by: Anthony Liguori
> 
> Regards,
> 
> Anthony Liguori


Jun
---
Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.