Re: [Xen-devel] Submit a patch

[Robin van Leeuwen <rvl@xxxxxxxxxxx>]

Mark Williamson wrote:

> > If i want to submit a patch for something,
> > how can i do this? Just post it to this group?
> >    
> Absolutely - please go ahead!
>
> Best practice is:
> * Send patch as a unified diff that can be applied with patch -p1 (or send the 
> output of "hg export <rev>")
> * Send the patch inline in your mail (try sending a copy to yourself first to 
> make sure your mail client doesn't munge the whitespace)
> * If you haven't heard anything for a while, resend the patch (and mark it as 
> resent in the subject line) - since the mailing list is high-traffic, it can 
> be a somewhat lossy channel ;-)
> Cheers,
> Mark
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>  
Ok a test, with a problem i had yesterday with compiling secpol_tools.c
with the static flag on, on my Debian Unstable/Testing:
amd:/usr/src/xen-unstable.hg/tools/security# gcc -v
Reading specs from /usr/lib/gcc-lib/x86_64-linux-gnu/3.3.6/specs
Configured with: ../src/configure -v 
--enable-languages=c,c++,java,f77,pascal,objc,ada,treelang --prefix=/usr 
--mandir=/usr/share/man --infodir=/usr/share/info 
--with-gxx-include-dir=/usr/include/c++/3.3 --enable-shared 
--enable-__cxa_atexit --with-system-zlib --enable-nls 
--without-included-gettext --enable-clocale=gnu --enable-debug 
--enable-java-gc=boehm --enable-java-awt=xlib --enable-objc-gc 
--disable-multilib x86_64-linux-gnu
Thread model: posix
gcc version 3.3.6 (Debian 1:3.3.6-7)

I Solved it by commenting out the static flag in the Makefile... The 
diff is i hope the correct format:
PATCH also included in attachment:
-------------------------------------------------------------------------------------------------------------- 

# HG changeset patch
# User "Robin van Leeuwen - robin.van.leeuwen@xxxxxxxxxxxxxxxxxxx>"
# Patch fixing compile error given when compiling secpol_tool.com
# on AMD64. Problems are fixed by removing the static flag from
# The Makefile of tools/security/Makefile

diff -r dfbeb7da829f tools/security/Makefile
--- a/tools/security/Makefile   Thu Aug 18 19:51:46 2005
+++ b/tools/security/Makefile   Fri Aug 19 03:59:50 2005
@@ -2,7 +2,7 @@
include $(XEN_ROOT)/tools/Rules.mk

SRCS     = secpol_tool.c
-CFLAGS   += -static
+#CFLAGS   += -static
CFLAGS   += -Wall
CFLAGS   += -Werror
CFLAGS   += -O3

-------------------------------------------------------------------------------------------------------------- 

# HG changeset patch
# User "Robin van Leeuwen - robin.van.leeuwen@xxxxxxxxxxxxxxxxxxx>"
# Patch fixing compile error given when compiling secpol_tool.com
# on AMD64. Problems are fixed by removing the static flag from
# The Makefile of tools/security/Makefile

diff -r dfbeb7da829f tools/security/Makefile
--- a/tools/security/Makefile   Thu Aug 18 19:51:46 2005
+++ b/tools/security/Makefile   Fri Aug 19 04:09:35 2005
@@ -2,7 +2,7 @@
 include $(XEN_ROOT)/tools/Rules.mk

 SRCS     = secpol_tool.c
-CFLAGS   += -static
+#CFLAGS   += -static
 CFLAGS   += -Wall
 CFLAGS   += -Werror
 CFLAGS   += -O3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel